Skip to content

fix(rag): RAG-retrieved use USER role, AGENTIC RAG mode add missing retrieveConfig#949

Merged
LearningGp merged 3 commits into
agentscope-ai:mainfrom
guanxuc:fix-rag-0313
Mar 23, 2026
Merged

fix(rag): RAG-retrieved use USER role, AGENTIC RAG mode add missing retrieveConfig#949
LearningGp merged 3 commits into
agentscope-ai:mainfrom
guanxuc:fix-rag-0313

Conversation

@guanxuc
Copy link
Copy Markdown
Contributor

@guanxuc guanxuc commented Mar 13, 2026

AgentScope-Java Version

1.0.11

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team March 13, 2026 14:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...o/agentscope/core/rag/KnowledgeRetrievalTools.java 25.00% 5 Missing and 1 partial ⚠️
...in/java/io/agentscope/core/rag/GenericRAGHook.java 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@guanxuc
Copy link
Copy Markdown
Contributor Author

guanxuc commented Mar 13, 2026

The unit test has covered the code.

LearningGp
LearningGp requested changes Mar 23, 2026
View reviewed changes
Comment thread agentscope-core/src/main/java/io/agentscope/core/rag/KnowledgeRetrievalTools.java Outdated
Comment thread agentscope-core/src/main/java/io/agentscope/core/rag/GenericRAGHook.java Outdated
@guanxuc guanxuc requested a review from LearningGp March 23, 2026 11:22
@guanxuc
Copy link
Copy Markdown
Contributor Author

guanxuc commented Mar 23, 2026

@LearningGp Thanks for your code review and important point, I've fixed the code.

LearningGp
LearningGp approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp merged commit 9031dc3 into agentscope-ai:main Mar 23, 2026
5 of 6 checks passed
@guanxuc guanxuc deleted the fix-rag-0313 branch March 23, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LearningGp LearningGp LearningGp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]:GenericRAGHook should use user message [Bug]:ReActAgent AGENTIC RAG mode ignores retrieveConfig, causing configuration to be ineffective

2 participants

@guanxuc @LearningGp